Description: Module initialization method throws NotImplementedException, which can crash consumers at
runtime when the module is created via the new factory, creating a denial-of-service for
that functionality.
EmulationModule.cs [93-96]

protected internal override void Initialize(Broker broker)
{
    throw new NotImplementedException();
}

Description: Module initialization throws NotImplementedException, potentially causing runtime failures
and making the module unusable when created, leading to stability issues.
InputModule.cs [49-52]

protected internal override void Initialize(Broker broker)
{
    throw new System.NotImplementedException();
}

Description: Initialize method throws NotImplementedException which may be hit during module creation
via factory, causing unexpected termination at runtime.
LogModule.cs [38-41]

protected internal override void Initialize(Broker broker)
{
    throw new NotImplementedException();
}

Description: Initialize throws NotImplementedException, which could cause runtime failure when the
module is instantiated through Module.Create, leading to service disruption.
NetworkModule.cs [177-180]

protected internal override void Initialize(Broker broker)
{
    throw new System.NotImplementedException();
}

Description: Initialize method throws NotImplementedException, potentially breaking functionality at
runtime when storage module is created via factory.
StorageModule.cs [48-51]

protected internal override void Initialize(Broker broker)
{
    throw new System.NotImplementedException();
}

Description: Initialize throws NotImplementedException, risking runtime crashes when module factory
initializes JSON context or other settings.
WebExtensionModule.cs [41-44]

protected internal override void Initialize(Broker broker)
{
    throw new System.NotImplementedException();
}

Description: Broker exposes ConfigureJsonContext allowing arbitrary modification of shared
JsonSerializerOptions which may impact deserialization of untrusted WebSocket data across
modules, increasing risk of insecure parsing if misconfigured by extensions.
Broker.cs [111-119]

    // Add base BiDi generated context resolver; keep options mutable for module contexts
    _jsonSerializerOptions.TypeInfoResolverChain.Add(BiDiJsonSerializerContext.Default);
}

public void ConfigureJsonContext(Action<JsonSerializerOptions> action)
{
    // Keep options mutable; do not create a context bound to them (avoids InvalidOperationException)
    action(_jsonSerializerOptions);
}

Follow the guide to enable codebase context checks.

Follow the guide to enable custom compliance check.

The new abstract Initialize method is not properly implemented in most modules,
throwing NotImplementedException. These implementations must be completed to
prevent runtime exceptions when modules are created.

Examples:

    protected internal override void Initialize(Broker broker)
    {
        throw new NotImplementedException();
    }

    protected internal override void Initialize(Broker broker)
    {
        throw new System.NotImplementedException();
    }

Solution Walkthrough:

Before:

// In Module.cs
public static TModule Create<TModule>(Broker broker) where TModule : Module, new()
{
    TModule module = new();
    module.Broker = broker;
    module.Initialize(broker); // This will throw for most modules
    return module;
}

// In EmulationModule.cs, InputModule.cs, etc.
public sealed class EmulationModule : Module
{
    // ...
    protected internal override void Initialize(Broker broker)
    {
        throw new NotImplementedException();
    }
}

After:

// In Module.cs
public static TModule Create<TModule>(Broker broker) where TModule : Module, new()
{
    TModule module = new();
    module.Broker = broker;
    module.Initialize(broker); // This will no longer throw
    return module;
}

// In EmulationModule.cs, InputModule.cs, etc.
public sealed class EmulationModule : Module
{
    // ...
    protected internal override void Initialize(Broker broker)
    {
        // Implementation for JSON serialization context, or empty if not needed.
        // For example:
        // broker.ConfigureJsonContext(opts => opts.TypeInfoResolverChain.Add(EmulationModuleJsonSerializerContext.Default));
    }
}

Remove the NotImplementedException from the Initialize method in EmulationModule
and other modules. If no initialization is needed, the method body should be
empty to prevent runtime crashes.

dotnet/src/webdriver/BiDi/Emulation/EmulationModule.cs [93-96]

 protected internal override void Initialize(Broker broker)
 {
-    throw new NotImplementedException();
+    // No-op for this module.
 }

• Apply / Chat

Implement the Initialize method in BrowsingContextModule to register a
module-specific JsonSerializerContext. This aligns with the pattern in
BrowserModule and is necessary for proper JSON serialization.

dotnet/src/webdriver/BiDi/BrowsingContext/BrowsingContextModule.cs [254-257]

 protected internal override void Initialize(Broker broker)
 {
-    
+    broker.ConfigureJsonContext(opts => opts.TypeInfoResolverChain.Add(BrowsingContextModuleJsonSerializerContext.Default));
 }

• Apply / Chat

Add a null check for the incoming broker to fail fast with a clear error if it's
not provided.

dotnet/src/webdriver/BiDi/Module.cs [30-36]

 public static TModule Create<TModule>(Broker broker) where TModule : Module, new()
 {
+    if (broker is null) throw new ArgumentNullException(nameof(broker));
     TModule module = new();
     module.Broker = broker;
     module.Initialize(broker);
     return module;
 }

• Apply / Chat